Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos#21591
Open
anders-nexthop wants to merge 2 commits intosonic-net:masterfrom
Open
Issue 20728: Enhance configlet/test_add_rack.py for ipv6-only topos#21591anders-nexthop wants to merge 2 commits intosonic-net:masterfrom
anders-nexthop wants to merge 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anders-nexthop
force-pushed
the
anders.20728.test_add_rack-for-ipv6
branch
from
901068c to
71be742
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anders-nexthop
force-pushed
the
anders.20728.test_add_rack-for-ipv6
branch
from
71be742 to
ede382f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anders-nexthop
force-pushed
the
anders.20728.test_add_rack-for-ipv6
branch
from
ede382f to
aa1938f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw |
anders-nexthop
force-pushed
the
anders.20728.test_add_rack-for-ipv6
branch
from
aa1938f to
fbf5115
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@yanmo96 Can you help review this PR? Thanks |
anders-nexthop
force-pushed
the
anders.20728.test_add_rack-for-ipv6
branch
from
fbf5115 to
c23e5ca
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
previously approved these changes
Feb 27, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Reviewed: handles IPv4/IPv6-only neighbor checks; looks good. Minor nit in comment.
anders-nexthop
force-pushed
the
anders.20728.test_add_rack-for-ipv6
branch
from
c23e5ca to
d9b2185
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anders-nexthop
force-pushed
the
anders.20728.test_add_rack-for-ipv6
branch
from
d9b2185 to
d78a2d3
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Good catch. Looking at it again, I noticed that we had the same logic repeated in three places. I refactored it into a helper, and incorported your suggestion there. I think this is a bit cleaner. @yxieca please take another look when you get a chance, thanks. |
yxieca
approved these changes
Feb 27, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying: Re-approved; changes look good. Ready once CI is green.
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic. Signed-off-by: Anders Linn <anders@nexthop.ai>
Signed-off-by: Anders Linn <anders@nexthop.ai>
anders-nexthop
force-pushed
the
anders.20728.test_add_rack-for-ipv6
branch
from
d78a2d3 to
144e027
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Currently, the test checks for both ipv4 and ipv6 neighbors unconditionally, and will fail if either is missing. Change that behavior to instead check to see if neighbors exist before running the bgp checks. Add a failure case if no neighbors are found in either AF. This way the test is AF-agnostic.
Closes #20728
Type of change
Back port request
Approach
What is the motivation for this PR?
Extend coverage for IPv6-only topos
How did you do it?
Add logic to check whether v4/v6 neighbor ips exist before checking whether they are up. If no neighbor ips are found at all, the test fails.
How did you verify/test it?
Ran the test on a vs topo with only v6 neighbors. It fails before these changes and passes after they are added.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation