Skip to content

check detect time samples before accessing list by index in test_pfcw… #22250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StormLiangMS merged 1 commit into from
Mar 3, 2026
Merged

check detect time samples before accessing list by index in test_pfcw… #22250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/pfcwd/test_pfcwd_timer_accuracy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,22 @@ def verify_pfcwd_timers(self):
)
break

# Validate that we have enough samples before accessing list by index
# If more than half of iterations failed to collect timestamps, fail with a clear message
required_samples = check_point + 1
detect_count = len(self.all_detect_time)
restore_count = len(self.all_restore_time)
if detect_count < required_samples or restore_count < required_samples:
detect_failures = ITERATION_NUM - detect_count
restore_failures = ITERATION_NUM - restore_count
pytest.fail(
"Too many iterations failed to collect PFCWD timestamps. "
"Detect time samples: {}/{} (failures: {}), Restore time samples: {}/{} (failures: {}). "
"Required at least {} samples. This may indicate environment or timing issues.".format(
detect_count, ITERATION_NUM, detect_failures,
restore_count, ITERATION_NUM, restore_failures,
required_samples))

err_msg = ("Real detection time is greater than configured: Real detect time: {} "
"Expected: {} (wd_detect_time + wd_poll_time)".format(self.all_detect_time[check_point],
config_detect_time))
Expand Down
Loading