Change BGP peering timeout to 120#22693
Open
fkong-cisco wants to merge 1 commit intosonic-net:masterfrom
Open
Conversation
bpar9
approved these changes
Mar 2, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In test_bgp_slb.py, the dynamic peers bring up timeout is set at 40 seconds using the number "40", while in many other tests, it is using WAIT_TIMEOUT, with value of 120. So I'm changing it to do the same.
Other uses of "WAIT_TIMEOUT":
fkong@vxr-slurm-254:/nobackup/fkong/sonic-mgmt-tests/sonic-test/sonic-mgmt/tests/bgp$ grep WAIT_TIMEOUT * | grep "="
grep: reliable_tsabgp_helpers.py:WAIT_TIMEOUT = 120
bgp_helpers.py:TCPDUMP_WAIT_TIMEOUT = 20
: Is a directory
grep: templates: Is a directory
test_bgp_peer_shutdown.py:WAIT_TIMEOUT = 120
test_bgp_slb.py:WAIT_TIMEOUT = 120
test_bgp_update_replication.py:WAIT_TIMEOUT = 120
test_bgp_update_timer.py:WAIT_TIMEOUT = 120
fkong@vxr-slurm-254:/nobackup/fkong/sonic-mgmt-tests/sonic-test/sonic-mgmt/tests/bgp$
Summary:
Fixes # MIGSOFTWAR-33363
Type of change
Script change
Back port request