Add missing t1-64 EOS templates and enable test topology mark#22695
Open
mattkim25 wants to merge 1 commit intosonic-net:masterfrom
Open
Add missing t1-64 EOS templates and enable test topology mark#22695mattkim25 wants to merge 1 commit intosonic-net:masterfrom
mattkim25 wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add missing EOS startup-config template entries for t1-64 by introducing `t1-64-spine.j2` and `t1-64-tor.j2` in `ansible/roles/eos/templates` Also update `tests_mark_conditions.yaml` to include `t1-64` as a valid test topoloy. Signed-off-by: Matthew Kim <mkim@upscaleai.com>
mattkim25
force-pushed
the
missing_files_for_topo_t1-64
branch
from
477e3c5 to
d9d944c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR fixes
t1-64topology bring-up issues insonic-mgmtby addressing three problems:Fixes typo in
ansible/vars/topo_t1-64.yml:bp_interfaces->bp_interfaceAdds missing EOS templates for
t1-64by using symlinks:ansible/roles/eos/templates/t1-64-spine.j2->t1-lag-spine.j2ansible/roles/eos/templates/t1-64-tor.j2->t1-64-lag-tor.j2Enables COPP test execution on
t1-64by addingt1-64to topology allowlists in:tests/common/plugins/conditional_mark/tests_mark_conditions.yamlFixes Issues:
Type of change
Back port request
Approach
What is the motivation for this PR?
testbed_add_vm_topologyont1-64failed due to:bp_interfaces)t1-64role resolutionAdditionally, COPP conditional marks did not include
t1-64, causing unnecessary skips for that topology.How did you do it?
bp_interfacestobp_interfaceinansible/vars/topo_t1-64.yml.t1-64-spine.j2->t1-lag-spine.j2t1-64-tor.j2->t1-64-lag-tor.j2t1-64in:tests/common/plugins/conditional_mark/tests_mark_conditions.yamlHow did you verify/test it?
I ran t1 sonic-mgmt tests using the t1-64 topology.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation