Add pytest.mark.disable_route_check to static route tests#22697
Open
anamehra wants to merge 1 commit intosonic-net:masterfrom
Open
Add pytest.mark.disable_route_check to static route tests#22697anamehra wants to merge 1 commit intosonic-net:masterfrom
anamehra wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Anand Mehra (anamehra) <anamehra@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
approved these changes
Mar 4, 2026
Contributor
cyw233
left a comment
There was a problem hiding this comment.
Reviewed the change — looks good. ✅
Summary: Adds pytest.mark.disable_route_check to the static route GCU tests.
- Correct pattern — Other GCU tests that modify routing state (ECMP, NTP, etc.) already use this marker. This is consistent with the existing convention.
- Valid rationale — Static route tests add/remove/rollback routes, causing transient route convergence states that trip
routeCheckwith false failures, especially on multi-ASIC platforms. - Minimal & safe — Single-line, low-risk change that only suppresses an irrelevant validation for these specific tests.
No issues found.
Contributor
|
Hi @anamehra, do we need to have a test-level |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add
pytest.mark.disable_route_checkto the generic config updater static route tests so the route-check service is not run for these tests. This avoids failures from routeCheck during teardown/rollback (e.g. on multi-ASIC) that are expected and do not affect the DUT, and matches the pattern used by other GCU tests that change routing state.disable_route_checkskips the route-check validation for these tests and prevents those expected convergence-related failures from failing the run.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation