Fix testbed deadlock from fork in threads#22706
Open
suwinkumar-arista wants to merge 1 commit intosonic-net:masterfrom
Open
Fix testbed deadlock from fork in threads#22706suwinkumar-arista wants to merge 1 commit intosonic-net:masterfrom
suwinkumar-arista wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: suwinkumar-arista <suwinkumar@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fixes deadlock observed in a few servers where tests would hang indefinitely. Root cause was fork() being called within
thread context via SafeThreadPoolExecutor, causing child processes to inherit locked import mutex that could never be released (orphan lock scenario). This is more prevalent in DualToR scenarios where shell commands run in parallel across two threads.
How did you do it?
Solution serializes collect_before_test, collect_after_test, and print_logs operations to eliminate fork within threading context.
How did you verify/test it?
Tested on Arista-7050CX3 running dualtor-aa topology
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation