Fix false traffic disruption from PF_PACKET sniffer drops#22708
Open
rajkumar1-arista wants to merge 1 commit intosonic-net:masterfrom
Open
Fix false traffic disruption from PF_PACKET sniffer drops#22708rajkumar1-arista wants to merge 1 commit intosonic-net:masterfrom
rajkumar1-arista wants to merge 1 commit intosonic-net:masterfrom
Conversation
For dualtor_sniffer script, all interfaces are sharing one PF_PACKET socket with a default SO_RCVBUF of only 128KB. During scapy's per-packet Python processing, brief pauses cause this small buffer to overflow, silently dropping packets. The test then misinterprets missing sniffer captures as forwarding disruptions. Increase SO_RCVBUF to 32MB to absorb processing pauses. Signed-off-by: rajkumar1 <rajkumar1@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # #21043
Type of change
Back port request
Approach
What is the motivation for this PR?
dualtor_io.test_normal_op#test_mux_port_switch_active_server_to_active_serveranddualtor_io.test_normal_op#test_mux_port_switch_active_server_to_standby_serverare failing with 1 traffic disruptionsHow did you do it?
For dualtor_sniffer script, #18758 introduces single
PF_PACKETsocket for all interfaces, correspondingSO_RCVBUFof only128KBis not enough. During scapy's per-packet Python processing, brief pauses cause this small buffer to overflow, silently dropping packets. The test then misinterprets missing sniffer captures as forwarding disruptions.Increased SO_RCVBUF to 32MB to absorb processing pauses.
How did you verify/test it?
Ran the tests on dualtor-aa-56
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation