Link Flap: Adding interface and drop counter checks for continuous link flap test.#22711
Open
rraghav-cisco wants to merge 1 commit intosonic-net:masterfrom
Open
Link Flap: Adding interface and drop counter checks for continuous link flap test.#22711rraghav-cisco wants to merge 1 commit intosonic-net:masterfrom
rraghav-cisco wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
…nk flap test. Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
9fcdd62 to
70dc8d0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@yxieca : Regarding your comments in the older version of the PR(#22581):
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Adding checks for both interface counters and drop counters in continuous link flap test. This is to catch any problem that will cause the counters to go up drastically when the interfaces are flapping, or going down.
Type of change
Back port request
Approach
What is the motivation for this PR?
We saw some issues in interfaces where the ports were flapping, and the drop counters were going up drastically. This PR attempts to modify the existing test case to catch this condition.
How did you do it?
Added drop and interface counter checks to the test_cont_link_flap test.
How did you verify/test it?
Ran it on our platform: