[action] [PR:22494] [memory_utilization] Fix memory check issue for container_autorestart and logrotate#22715
Open
mssonicbld wants to merge 1 commit intosonic-net:202511from
Open
[action] [PR:22494] [memory_utilization] Fix memory check issue for container_autorestart and logrotate#22715mssonicbld wants to merge 1 commit intosonic-net:202511from
mssonicbld wants to merge 1 commit intosonic-net:202511from
Conversation
…-net#22494) What is the motivation for this PR? autorestart/test_container_autorestart.py::test_containers_autorestart, this is a case related to the container restart, need to skip the memory checker during the test simulate_small_var_log_partition memory checker collects memory before and after the case, so we need to make sure the test environment is stable before the case, it’s better to add the check for interface up and wait for bgp up in the fixture simulate_small_var_log_partition, config reload. config_reload(duthost, safe_reload=True) config_reload(duthost, safe_reload=True, check_intf_up_ports=True, wait_for_bgp=True) How did you do it? Skip the checker in autorestart/test_container_autorestart.py Waiting device stable before testing Signed-off-by: xuliping <xuliping@microsoft.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
12 tasks
Collaborator
Author
|
Original PR: #22494 |
Collaborator
Author
|
/azp run |
github-actions
bot
requested review from
Junchao-Mellanox and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
36843474
Type of change
Back port request
Approach
What is the motivation for this PR?
autorestart/test_container_autorestart.py::test_containers_autorestart, this is a case related to the container restart, need to skip the memory checker during the test
simulate_small_var_log_partition memory checker collects memory before and after the case, so we need to make sure the test environment is stable before the case, it’s better to add the check for interface up and wait for bgp up in the fixture simulate_small_var_log_partition, config reload.
config_reload(duthost, safe_reload=True)
config_reload(duthost, safe_reload=True, check_intf_up_ports=True, wait_for_bgp=True)
How did you do it?
Skip the checker in autorestart/test_container_autorestart.py
Waiting device stable before testing
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation