config_reload() options for CACL cleanup_scale_rules() function#22718
Open
madbabu-cisco wants to merge 1 commit intosonic-net:masterfrom
Open
config_reload() options for CACL cleanup_scale_rules() function#22718madbabu-cisco wants to merge 1 commit intosonic-net:masterfrom
madbabu-cisco wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Madhan Babu <madbabu@cisco.com>
|
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhaohuiS
approved these changes
Mar 4, 2026
anamehra
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Config reload options for CACL cleanup_scale_rules() function
Summary:
Fixes # (issue)
For a long time, it is observed that the test_cacl_scale_rules_ipv6 test case fails due to Increase in Memory threshold. And it also, reported an incorrect percentage in increase in System Memory.
Debugging the issue, it was found that cleanup_scale_rules() which was called as part of previous test case test_cacl_scale_rules_ipv4() teardown function, actually invokes config_reload() which does not complete the restart of syncd process fully. Hence, the VM RSS memory occupied by syncd is too low, which eventually becomes normal. So, the difference between "Before test" and "After test" "free -m" command "used" field increases more than 20% causing the test case to fail. Fixed it with adding to the config_reload() option of wait_for_bgp = True, which fixes the issue.
There was also a cosmetic issue of reporting Increased MB usage as Increased percentage usage. Fixed this issue also.
Type of change
Back port request
Approach
What is the motivation for this PR?
This CICD defect is there nearly for more than 3 months and the defect was frequently reproducible.
How did you do it?
Made the above two code changes required for threshold output formatting and fixed cleanup issue causing false positive
How did you verify/test it?
Added the fix and rerun the test
Any platform specific information?
It is across platforms - t0, t1 and t2.
Supported testbed topology if it's a new test case?
Existing test case
Documentation