[action] [PR:22340] Fix check_config_applied logic in set_dual_tor_state_to_orchagent#22720
Open
mssonicbld wants to merge 1 commit intosonic-net:202511from
Open
[action] [PR:22340] Fix check_config_applied logic in set_dual_tor_state_to_orchagent#22720mssonicbld wants to merge 1 commit intosonic-net:202511from
mssonicbld wants to merge 1 commit intosonic-net:202511from
Conversation
…nic-net#22340) What is the motivation for this PR? The previous check_config_applied function compared the total number of entries in MUX_CABLE_TABLE with the number of interfaces. However, MUX_CABLE_TABLE contains entries for all mux ports in the system (e.g., 24 ports in T0 KVM), which always remain the same. The previous implementation of check_config_applied() validated the mux state change by comparing the total number of entries in MUX_CABLE_TABLE with the number of interfaces being updated. When updating only a subset of interfaces, it causes the check to fail consistently and wait_until function to retry until the 2min timeout. How did you do it? By checking the state of each instead of comparing the total number of table entries. How did you verify/test it? Before the improvement: https://elastictest.org/scheduler/testplan/698bf70cbb7d1dad4c804782?searchTestCase=test_orchagent_active_tor_downstream&testcase=dualtor%2Ftest_orchagent_active_tor_downstream.py&type=log&leftSideViewMode=detail Signed-off-by: yawenni <yawenni@microsoft.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
12 tasks
Collaborator
Author
|
Original PR: #22340 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
https://msazure.visualstudio.com/One/_workitems/edit/36060751
Type of change
Back port request
Approach
What is the motivation for this PR?
The previous check_config_applied function compared the total number of entries in MUX_CABLE_TABLE with the number of interfaces. However, MUX_CABLE_TABLE contains entries for all mux ports in the system (e.g., 24 ports in T0 KVM), which always remain the same.
The previous implementation of check_config_applied() validated the mux state change by comparing the total number of entries in MUX_CABLE_TABLE with the number of interfaces being updated. When updating only a subset of interfaces, it causes the check to fail consistently and wait_until function to retry until the 2min timeout.
How did you do it?
By checking the state of each instead of comparing the total number of table entries.
How did you verify/test it?
Before the improvement:
https://elastictest.org/scheduler/testplan/698bf70cbb7d1dad4c804782?searchTestCase=test_orchagent_active_tor_downstream&testcase=dualtor%2Ftest_orchagent_active_tor_downstream.py&type=log&leftSideViewMode=detail
Now:
https://elastictest.org/scheduler/testplan/698c18b648d58f009f2c7b39?searchTestCase=test_orchagent_active_tor_downstream&testcase=dualtor%2Ftest_orchagent_active_tor_downstream.py&type=log&leftSideViewMode=detail
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation