Handle stale transient FEC errors in test_verify_fec_stats_counters#22733
Open
kewei-arista wants to merge 2 commits intosonic-net:masterfrom
Open
Handle stale transient FEC errors in test_verify_fec_stats_counters#22733kewei-arista wants to merge 2 commits intosonic-net:masterfrom
kewei-arista wants to merge 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: kewei <kewei@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
test_verify_fec_stats_countershas a similar issue astest_verify_fec_histogramthat has been fixed in #21685, where it may fail for a stable link that has stale transient FEC errors.This change follows the same approach as #21685 to fix the issue for
test_verify_fec_stats_countersby polling FEC counters for an interface for a longer time to determine whether the link has been stable, and not fail the test for a stable link with stale transient FEC errors.This change also optimizes the code path to poll FEC counters so we only need to do it once for both
test_verify_fec_stats_countersandtest_verify_fec_histogram, so this can save the polling time and speed up the whole test.This change also addresses the #21685 (comment) so the polling time is now test attribute driven.
Type of change
Back port request
Approach
What is the motivation for this PR?
Improve the pass rate by handling these corner cases
How did you do it?
Wait for enough long time to make sure the links are actually stable
How did you verify/test it?
Confirmed the test now can pass with a stable link but transient FEC symbol errors
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation