[sonic-redfish] Sonic Redfish support with OpenBMC and sonic-dbus-bridge #1
Draft
chinmoy-nexthop wants to merge 1 commit intosonic-net:masterfrom
Draft
[sonic-redfish] Sonic Redfish support with OpenBMC and sonic-dbus-bridge #1chinmoy-nexthop wants to merge 1 commit intosonic-net:masterfrom
chinmoy-nexthop wants to merge 1 commit intosonic-net:masterfrom
Conversation
…omponent - Add Makefile.build as central build orchestration with Docker-only builds - Add Docker build environment (debian:trixie) with all required dependencies - Add patch management system with series file for bmcweb integration - Add submodule setup scripts for bmcweb and sdbusplus dependencies - Add Docker container configuration for runtime deployment - Update README.md with build instructions and system architecture sonic-dbus-bridge component: - Implements D-Bus to Redis state synchronization for SONiC integration - Provides D-Bus interfaces for Redfish API consumption by bmcweb - Supports inventory management via FRU and platform JSON adapters - Implements user management with PAM integration - Implements software update management for BMC firmware - Uses Redis pub/sub for state change notifications - Built with C++23, Meson build system, and sdbusplus library Build system features: - Docker-only compilation for build consistency across environments - Meson-based builds for both bmcweb and sonic-dbus-bridge - C++23 support with proper dependency resolution via wrap files - Parallel build support via SONIC_CONFIG_MAKE_JOBS variable - Clean separation of build artifacts and source code Signed-off-by: Chinmoy Dey <chinmoy@nexthop.ai> Co-authored-by: Shreyansh Jain <shreyansh@nexthop.ai>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1 in repo sonic-net/sonic-redfish |
| # Check if bmcweb has local changes (patches applied) | ||
| if [ -d "bmcweb/.git" ]; then | ||
| cd bmcweb | ||
| if ! git diff --quiet || ! git diff --cached --quiet; then |
There was a problem hiding this comment.
Why git diff --cached --quiet ? We don't stage the patches we apply right?
|
|
||
| setup: | ||
| @$(SCRIPTS_DIR)/setup-submodules.sh | ||
| @$(SCRIPTS_DIR)/apply-patches.sh |
There was a problem hiding this comment.
Where is apply-patches.sh? Did you forget to git add?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenBMC Standard Compliance:
Mimicking OpenBMC:
Data Model Mismatch:
Keep bmcweb Pristine:
Hardware Data Aggregation:
Bidirectional Communication:
Graceful Degradation:
sonic-dbus-bridge component:
Build system features: