Local ARS (Adaptive Routing and Switching)#1002
Local ARS (Adaptive Routing and Switching)#1002VladimirKuk wants to merge 2 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
common/schema.h
Outdated
| #define PLUGIN_TABLE "PLUGIN_TABLE" | ||
| #define LUA_PLUGIN_TYPE "LUA_PLUGIN_TYPE" | ||
| #define SAI_OBJECT_TYPE "SAI_OBJECT_TYPE" | ||
| #define PFC_WD_POLL_MSECS 100 |
There was a problem hiding this comment.
Please revert the changes not applicable to this feature
common/schema.h
Outdated
| #define BMP_STATE_BGP_RIB_IN_TABLE "BGP_RIB_IN_TABLE" | ||
| #define BMP_STATE_BGP_RIB_OUT_TABLE "BGP_RIB_OUT_TABLE" | ||
|
|
||
| /* ARS */ |
There was a problem hiding this comment.
Better to move to lint602 with other state db table names.
common/schema.h
Outdated
|
|
||
| #define CFG_ARS_PROFILE "ARS_PROFILE" | ||
| #define CFG_ARS_INTERFACE "ARS_INTERFACE" | ||
| #define CFG_ARS_NEXTHOP_GROUP "ARS_NEXTHOP_GROUP" |
There was a problem hiding this comment.
also ARS_OBJECT table as per https://github.com/sonic-net/SONiC/pull/1958/files ?
There was a problem hiding this comment.
CFG_ macros are auto-generated from YANG models via cfg_schema.h. hence, this changes are removed from schema.h
Signed-off-by: Vladimir Kuk <vkuk@marvell.com>
340fb58 to
ade1897
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ade1897 to
b3164ac
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| #define APP_SWITCH_TABLE_NAME "SWITCH_TABLE" | ||
| #define APP_NEXTHOP_GROUP_TABLE_NAME "NEXTHOP_GROUP_TABLE" | ||
| #define APP_CLASS_BASED_NEXT_HOP_GROUP_TABLE_NAME "CLASS_BASED_NEXT_HOP_GROUP_TABLE" | ||
| #define APP_EVPN_SPLIT_HORIZON_TABLE_NAME "EVPN_SPLIT_HORIZON_TABLE" |
There was a problem hiding this comment.
Why remove existing definition?
There was a problem hiding this comment.
Because of a merge conflict the file was removed, and i have restored it now.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
d9f7cd7 to
95cfa52
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Vladimir Kuk <vkuk@marvell.com>
95cfa52 to
be2ac51
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss-common (Test vstest) |
|
/AzurePipelines run Azure.sonic-swss-common (Test vstest) |
|
No pipelines are associated with this pull request. |
|
/azpw run Azure.sonic-swss-common (Test vstest) |
|
/AzurePipelines run Azure.sonic-swss-common (Test vstest) |
|
No pipelines are associated with this pull request. |
|
hi @prsunny We have addressed all the open comments. Can you please review and merge. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This pull request adds initial schema support for local ARS (Adaptive Routing and Switching) by defining two new table names in the STATE database. These definitions lay the groundwork for the ARS feature implementation as described in the linked HLD document.
Changes:
- Added two STATE database table name definitions for ARS feature: ARS_PROFILE_TABLE and ARS_CAPABILITY_TABLE
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1002 in repo sonic-net/sonic-swss-common |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
No pipelines are associated with this pull request. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
No pipelines are associated with this pull request. |
Added support for local ARS (Adaptive Routing and Switching).
HLD: sonic-net/SONiC#1958