ZMQ lib change to support one-to-one sync.#1039
Draft
divyagayathri-hcl wants to merge 1 commit intosonic-net:masterfrom
Draft
ZMQ lib change to support one-to-one sync.#1039divyagayathri-hcl wants to merge 1 commit intosonic-net:masterfrom
divyagayathri-hcl wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
fed6358 to
5782205
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
5782205 to
eeace8f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
eeace8f to
ecb8cea
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
ecb8cea to
ada8a91
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
divyagayathri-hcl
changed the title
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
ada8a91 to
2475d0b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
2475d0b to
af8d873
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
af8d873 to
baa2223
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
baa2223 to
d103b0b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
one-to-one
branch
from
d103b0b to
ba95574
Compare
Collaborator
|
/azp run |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mint570
reviewed
Feb 28, 2026
common/zmqclient.cpp
Outdated
| :ZmqClient(endpoint, "") | ||
| { | ||
| } | ||
| ZmqClient::ZmqClient(const std::string& endpoint) : ZmqClient(endpoint, "") {} |
Contributor
There was a problem hiding this comment.
I don't see change here. Can you limit the change to the needed lines?
| return; | ||
| } | ||
|
|
||
| std::lock_guard<std::mutex> lock(m_socketMutex); |
| class ZmqProducerStateTable : public ProducerStateTable | ||
| { | ||
| public: | ||
| ZmqProducerStateTable(DBConnector *db, const std::string &tableName, ZmqClient &zmqClient, bool dbPersistence = true); |
Contributor
There was a problem hiding this comment.
Many of the lines are no update. Don't make changes if there are no difference.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: mint570 <runmingwu@google.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Introduced one-to-one synchronization option (request/replay) in the ZMQ client and server implementation. This is a new addition to the existing push/pull model.
Why I did it
To ensure reliable and faster message delivery and synchronization between ZMQ producer and consumer in scenarios where message acknowledgment or ordering is critical. This will be used only by P4RT and P4Orch for now.
How I verified it
Ran unit tests in zmq_state_ut.cpp and confirmed a successful message exchange using the updated one-to-one sync logic.
Verified zmq_recv and zmq_send retry logic operates correctly using debug logs.
Details if related
None.