Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ic-net#1070) sonic-db-cli does not currently support calling the dpu redis instances that exist on smartswitches. This changes adds a -d/--dpu flag to select a dpu redis instance for running commands so that dpu instances can be targeted by the sonic-db-cli from the host OS
* PTF build still uses buster which does not support INSTANTIATE_TEST_SUITE_.
This changes fixes the error below
```
tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token
INSTANTIATE_TEST_SUITE_P(
^
tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
)
^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1
```
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
jasper-hou-micas
force-pushed
the
igmp-snp
branch
from
e77d7ae to
eb63217
Compare
Signed-off-by: Jasper.Hou <jasper@micasnetworks.com>
Signed-off-by: Jasper.Hou <jasper@micasnetworks.com>
|
/azp run |
jasper-hou-micas
force-pushed
the
igmp-snp
branch
from
eb63217 to
6ec8769
Compare
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aidan-gallagher
left a comment
aidan-gallagher
left a comment
There was a problem hiding this comment.
This PR bundles three separate pieces: L2MC table schema definitions, a generic DebugFramework, and SWIG binding updates. The L2MC schema definitions have naming inconsistencies and the debug framework has thread safety and semantic issues.
The DebugFramework is a generic debug/dump system unrelated to L2MC or IGMP snooping. Separating it into its own PR would make both components easier to review.
| Critical | High | Medium | Low | Total |
|---|---|---|---|---|
| 2 | 7 | 5 | 6 | 20 |
Low-severity findings (pass-by-value in typedefs, unused member variables, #include "syslog.h" vs <syslog.h>) are omitted from inline comments but noted in the full review.
| #include "dbconnector.h" | ||
| #include "table.h" | ||
|
|
||
| using namespace swss; |
There was a problem hiding this comment.
Critical: using namespace swss; at file scope in a public header. This pollutes the global namespace for every consumer of libswsscommon that includes this header (directly or transitively via SWIG at pyext/swsscommon.i:365).
@aidan-gallagher |
Signed-off-by: Jasper.Hou <jasper@micasnetworks.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 participants
No description provided.