Skip to content

[orchagent] CoPP neighbor miss trap and enhancements #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rminnikanti
Copy link

@rminnikanti rminnikanti commented Apr 22, 2025

What I did

  • Added neighbor_miss trap type support
  • enum capability query for hostif trap type in copporch.cpp
  • Added hw_status field to COPP_TRAP_TABLE table in state_db

Why I did it

HLD: sonic-net/SONiC#1943

How I verified it

Verified with test_copp.py DVS test
Verified on Sonic switch with and without neighbor_miss trap support by vendorSAI.

Details if related

PR Dependencies:

Signed-off-by: Ravi Minnikanti [email protected]

@rminnikanti rminnikanti requested a review from prsunny as a code owner April 22, 2025 14:34
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rminnikanti
Copy link
Author

@prsunny @kcudnik PR check compilation failing because of dependency on sonic-swss-common PR - sonic-net/sonic-swss-common#1010
Can you please suggest if there is a way to run PR checks with dependencies?

@kcudnik
Copy link
Contributor

kcudnik commented Apr 25, 2025

there is no way to run code without dependency checked in, technically you could modify azure pipeline to pull swss common at specific commit, compile it and then build against that, but this is not standard approach and it would break everything else

@rminnikanti
Copy link
Author

Thank you for your response. Can the dependency PR be merged to allow the PR checks to run on this PR?
dependency - sonic-net/sonic-swss-common#1010

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msherif1234
Copy link

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rminnikanti
Copy link
Author

do you need to also update mock test json file https://github.com/sonic-net/sonic-swss/pull/3646/files#diff-7a754ce5badfcc6c7f079baabf320c731eab42f9f98194df7ec53eccb0e6064bR106 ?

mock_tests/copp_cfg.json is being used in coppmgrd UT.
I still updated it as suggested for consistency.

@msherif1234
Copy link

I created PR under sonic-mgmt to add new CoPP configs for this new trap type PTAL
sonic-net/sonic-mgmt#18480

@rminnikanti
Copy link
Author

I created PR under sonic-mgmt to add new CoPP configs for this new trap type PTAL sonic-net/sonic-mgmt#18480

@msherif1234 I have sonic-mgmt implemented for this HLD which already covers validating neighbor_miss traffic with default 200PPS if the neighbor_miss trap is supported sonic-net/sonic-mgmt#18326

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

What I did
* Added neighbor_miss trap type support
* enum capability query for hostif trap type
* Added trap hw_status field to state_db

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msherif1234
Copy link

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants