-
Notifications
You must be signed in to change notification settings - Fork 588
[orchagent] CoPP neighbor miss trap and enhancements #3624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
4426b26
to
878b552
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@prsunny @kcudnik PR check compilation failing because of dependency on sonic-swss-common PR - sonic-net/sonic-swss-common#1010 |
there is no way to run code without dependency checked in, technically you could modify azure pipeline to pull swss common at specific commit, compile it and then build against that, but this is not standard approach and it would break everything else |
Thank you for your response. Can the dependency PR be merged to allow the PR checks to run on this PR? |
878b552
to
7137a39
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
do you need to also update mock test json file https://github.com/sonic-net/sonic-swss/pull/3646/files#diff-7a754ce5badfcc6c7f079baabf320c731eab42f9f98194df7ec53eccb0e6064bR106 ? |
7137a39
to
b922219
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
mock_tests/copp_cfg.json is being used in coppmgrd UT. |
I created PR under sonic-mgmt to add new CoPP configs for this new trap type PTAL |
@msherif1234 I have sonic-mgmt implemented for this HLD which already covers validating neighbor_miss traffic with default 200PPS if the neighbor_miss trap is supported sonic-net/sonic-mgmt#18326 |
b922219
to
1fe2606
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
1fe2606
to
df140c2
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/lgtm |
What I did
Why I did it
HLD: sonic-net/SONiC#1943
How I verified it
Verified with test_copp.py DVS test
Verified on Sonic switch with and without neighbor_miss trap support by vendorSAI.
Details if related
PR Dependencies:
Signed-off-by: Ravi Minnikanti [email protected]