-
Notifications
You must be signed in to change notification settings - Fork 712
Add CLI show commands to view bgp network, neighbors and summary on per-vrf basis #3866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NavdhaJindal
wants to merge
26
commits into
sonic-net:master
Choose a base branch
from
NavdhaJindal:dev/navdhajindal/bgp-cli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add CLI show commands to view bgp network, neighbors and summary on per-vrf basis #3866
NavdhaJindal
wants to merge
26
commits into
sonic-net:master
from
NavdhaJindal:dev/navdhajindal/bgp-cli
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
anish-n
reviewed
May 8, 2025
tests/show_bgp_neighbor_test.py
Outdated
@@ -35,7 +50,7 @@ def executor(test_vector, show): | |||
if 'rc_warning_msg' in input: | |||
output = result.output.strip().split("\n")[0] | |||
assert input['rc_warning_msg'] in output | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove spacing change
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
anish-n
approved these changes
May 12, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sudarshankumar4893
approved these changes
May 12, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modified the existing 'show ip bgp [summary/neighbors/network]' CLIs to display bgp information for specific vrfs. The new CLIs have similar outputs to their
default VRF
counterparts:How I did it
Modified bgp_frr_v4.py and bgp_frr_v6.py to add a subcommand 'vrf' that accepts a vrf_name as an argument
How to verify it
UT coverage in show_bgp_neighbor_test.py, show_bgp_neighbor_test.py and bgp_commands_test.py
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)