-
Notifications
You must be signed in to change notification settings - Fork 714
Pr json support queue and priority-group watermark and persistent-watermark #3875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vikumarks
wants to merge
16
commits into
sonic-net:master
Choose a base branch
from
vikumarks:pr-json-support-queue-watermark
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2bfe3f2
Added json output support for queue watermark and persistent-watermark
vikumarks 64d50a5
Merge pull request #2 from vikumarks/work-json-support-queue-watermark
vikumarks 875621a
Merge branch 'sonic-net:master' into work-json-support-queue-watermark
vikumarks 9c9af8c
Merge branch 'sonic-net:master' into pr-json-support-queue-watermark
vikumarks ad15ab6
Merge branch 'sonic-net:master' into work-json-support-queue-watermark
vikumarks a6392b6
pre-commit checks fixes
vikumarks ed96b14
Merge branch 'sonic-net:master' into pr-json-support-queue-watermark
vikumarks 62cccbe
Merge branch 'pr-json-support-queue-watermark' into work-json-support…
vikumarks 13f08ae
Merge pull request #4 from vikumarks/work-json-support-queue-watermark
vikumarks 0857123
Merge branch 'sonic-net:master' into work-json-support-queue-watermark
vikumarks 9b64b87
Merge branch 'sonic-net:master' into pr-json-support-queue-watermark
vikumarks a813763
pg watermak json also added
vikumarks 7b591ac
Merge pull request #7 from vikumarks/work-json-support-queue-watermark
vikumarks fdb808a
pre-commit check fixes
vikumarks a3a2552
Merge pull request #8 from vikumarks/work-json-support-queue-watermark
vikumarks a8ffcb9
Merge branch 'sonic-net:master' into pr-json-support-queue-watermark
vikumarks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider using a consistent help message for the JSON flag across all commands. For example, align this with the 'Display JSON output' help text used elsewhere.
Copilot uses AI. Check for mistakes.