Fix route_check.py to ignore local p2p IP prefixes #3882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
227374e to
da49c12
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
da49c12 to
44dcf95
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* In some cases where there are repeated link flaps, route_check.py flags local
p2p IP prefixes as missing in APPL_DB. These /31 IPv4 or /126 IPv6 IPs are
not expected to be present in APPL_DB after a link goes down. This change
tries to filter out such entries.
Failure results: {{
"missed_ROUTE_TABLE_routes": [
"10.10.196.16/31",
"2603:10b0:31f:753::24/126"
]
}}
Failed. Look at reported mismatches above
add: []
del: [
"10.10.196.16/31",
"2603:10b0:31f:753::24/126"
]
Signed-off-by: Prabhat Aravind <[email protected]>
prabhataravind
force-pushed
the
paravind/route_check
branch
from
44dcf95 to
c03c087
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases where there are repeated link flaps, route_check.py flags local p2p IP prefixes as missing in APPL_DB. These /31 IPv4 or /126 IPv6 IPs are not expected to be present in APPL_DB after a link goes down. This change tries to filter out such entries.
Failure results: {{
"missed_ROUTE_TABLE_routes": [
"10.10.196.16/31",
"2603:10b0:31f:753::24/126"
]
}}
Failed. Look at reported mismatches above
add: []
del: [
"10.10.196.16/31",
"2603:10b0:31f:753::24/126"
]
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)