Limit PFC WD Detection time to maximum value of 1000[ms]#4188
Closed
dprital wants to merge 2 commits intosonic-net:masterfrom
Closed
Limit PFC WD Detection time to maximum value of 1000[ms]#4188dprital wants to merge 2 commits intosonic-net:masterfrom
dprital wants to merge 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
stephenxs
approved these changes
Jan 12, 2026
Contributor
|
@kperumalbfn Can you help review? |
Contributor
|
@dprital CPU consumption is a concern. I think that's also why we calculate the interval based on the number of ports. How do we ensure CPU has enough time to handle the redis queries? |
Collaborator
Author
Tested on two systems (MSN2700 and MSN4600C) by running pfc_wd sonic-mgmt tests. all tests passed. |
Collaborator
|
@dprital can you please add the explanation of the logic as well as the max set to the code? and please extend the code coverage by extending the code to also check the 32 ports systems and 512 ports system. |
dprital
force-pushed
the
master_limit_pfc_wd_detection_time
branch
from
55fee42 to
64fda1a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
force-pushed
the
master_limit_pfc_wd_detection_time
branch
from
64fda1a to
beeccb6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
force-pushed
the
master_limit_pfc_wd_detection_time
branch
from
beeccb6 to
cda4aac
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: dprital <drorp@nvidia.com>
dprital
force-pushed
the
master_limit_pfc_wd_detection_time
branch
from
cda4aac to
18e7130
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
force-pushed
the
master_limit_pfc_wd_detection_time
branch
from
6ec96e2 to
449c045
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
force-pushed
the
master_limit_pfc_wd_detection_time
branch
from
449c045 to
6655b4f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
force-pushed
the
master_limit_pfc_wd_detection_time
branch
from
6655b4f to
932c595
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: dprital <drorp@nvidia.com>
dprital
force-pushed
the
master_limit_pfc_wd_detection_time
branch
from
932c595 to
0a07430
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Closing this in favor of #4306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing: sonic-net/sonic-buildimage#25033
Should be merged before: sonic-net/sonic-buildimage#25034
What I did
PFC WD Detection time is defined by the following calculation:
DEFAULT_POLL_INTERVAL * multiply
where:
There is an allowed range for this value which is between 100..3000 [ms].
For system with more than 448 ports, we will violate this range.
In addition, there is no meaning to have detection time of more than 1000[ms], hence, this change limit the maximum detection time for PFC WD to 1000[ms]
How I did it
Calculate PFC WD Detection time, if it become bigger than 1000[ms], set it to 1000[ms]
How to verify it
Run PFC WD Tests on several platforms
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)