[acl-loader]: Wait for rules to be removed before installing new ones#4203
Draft
MavChtz wants to merge 1 commit intosonic-net:masterfrom
Draft
[acl-loader]: Wait for rules to be removed before installing new ones#4203MavChtz wants to merge 1 commit intosonic-net:masterfrom
MavChtz wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
MavChtz
force-pushed
the
acl-loader-fix-rule-inconsistencies
branch
from
5ab3cae to
b134747
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MavChtz
force-pushed
the
acl-loader-fix-rule-inconsistencies
branch
from
b134747 to
832dd7f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MavChtz
force-pushed
the
acl-loader-fix-rule-inconsistencies
branch
from
832dd7f to
12df017
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MavChtz
force-pushed
the
acl-loader-fix-rule-inconsistencies
branch
from
12df017 to
9f07df5
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MavChtz
force-pushed
the
acl-loader-fix-rule-inconsistencies
branch
from
9f07df5 to
7473e8e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MavChtz
force-pushed
the
acl-loader-fix-rule-inconsistencies
branch
from
7473e8e to
95ba958
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
When running 'acl-loader update full' multiple consecutive times, with an ACL rule set that exceeds the TCAM's capacity, the newly installed ACL rules differ between iterations. full_update() now waits for existing rules to be removed by polling State DB before proceeding with new rule installations, thus yielding a deterministic rule set between runs. incremental_update() has also been adjusted as it handles dataplane rules in the same way. Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
MavChtz
force-pushed
the
acl-loader-fix-rule-inconsistencies
branch
from
95ba958 to
8e02dd1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running 'acl-loader update full' multiple consecutive times, with an ACL rule set that exceeds the TCAM's capacity,
the newly installed ACL rules differ between iterations.
full_update() now waits for existing rules to be removed by polling State DB before proceeding with new rule installations, thus yielding a deterministic rule set between runs.
incremental_update() has also been adjusted as it handles dataplane rules in the same way.