Make 'show version' docker images output conditional on '--verbose' flag#4288
Open
ashwnsri wants to merge 3 commits intosonic-net:masterfrom
Open
Make 'show version' docker images output conditional on '--verbose' flag#4288ashwnsri wants to merge 3 commits intosonic-net:masterfrom
ashwnsri wants to merge 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ashwnsri
changed the title
ashwnsri
force-pushed
the
show-version-verbose
branch
from
130c7d2 to
b21200e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What I did Modified the `show version` command to only display Docker image information when the `--verbose` flag is provided. How I did it Updated the `version` function in `src/sonic-utilities/show/main.py`. Added a conditional check `if verbose:` around the code block that retrieves and prints the Docker images list. How to verify it 1. Run `show version` and verify that the output shows the version/platform information but does NOT list the Docker images. 2. Run `show version --verbose` and verify that the output includes the "Docker images:" section with the list of images at the end. Previous command output New command output Signed-off-by: Ashwin Srinivasan <asrinivasan@juniper.net>
ashwnsri
force-pushed
the
show-version-verbose
branch
from
b21200e to
d9a66de
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ashwin Srinivasan <asrinivasan@juniper.net>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ashwin Srinivasan <asrinivasan@juniper.net>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Modified the
show versioncommand to only display Docker image information when the--verboseflag is provided.How I did it
Updated the
versionfunction insrc/sonic-utilities/show/main.py. Added a conditional checkif verbose:around the code block that retrieves and prints the Docker images list.How to verify it
show versionand verify that the output shows the version/platform information but does NOT list the Docker images.show version --verboseand verify that the output includes the "Docker images:" section with the list of images at the end.Previous command output (if the output of a command-line utility has changed)
old-show-ver-output.txt
New command output (if the output of a command-line utility has changed)
new-show-ver-output.txt
Signed-off-by: Ashwin Srinivasan ashwin.srinivasan@hpe.com