scripts/generate_dump: Fix duplicate generate_dump entry#4300
Open
yxu-lumentum wants to merge 1 commit intosonic-net:masterfrom
Open
scripts/generate_dump: Fix duplicate generate_dump entry#4300yxu-lumentum wants to merge 1 commit intosonic-net:masterfrom
yxu-lumentum wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Replace incorrect removal of 'sonic_dump' with 'generate_dump' Signed-off-by: Yi Xu Yi.Xu@lumentum.com Signed-off-by: Yi Xu <Yi.Xu@lumentum.com>
yxu-lumentum
force-pushed
the
dump_script_bugfix
branch
from
d9d92fb to
6047a18
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4292
What I did
The
generate_dumpscript creates a symlink to itself in the dump directory before generating the initial tar archive. However, due to a typo in the cleanup step, the symlink was not correctly removed. As a result, when the dump directory was appended later usingsave_to_tar, thegenerate_dumpentry was added a second time.This patch corrects the cleanup target so that
generate_dumpsymlink is properly removed, preventing duplicate.How I did it
Updated the cleanup step in
generate_dump:From:
$RM $V -f $TARDIR/sonic_dumpTo:
$RM $V -f $TARDIR/generate_dumpHow to verify it
show techsupporton a SONiC target device./var/dump. It should look likesonic_dump_sonic_20260116_001237.tar.gz.generate_dump.Signed-off-by: Yi Xu Yi.Xu@lumentum.com