Show error message when FEC histogram is not available#4308
Open
eder-arista wants to merge 1 commit intosonic-net:masterfrom
Open
Show error message when FEC histogram is not available#4308eder-arista wants to merge 1 commit intosonic-net:masterfrom
eder-arista wants to merge 1 commit intosonic-net:masterfrom
Conversation
When the SAI_PORT_STAT_IF_IN_FEC_CODEWORD_ERRORS_S[0-15] counter is not available on COUNTERS_DB, the command `show interfaces fec-histogram` prints all bins with value equals zero without any error message. This change fixes this behavior. Signed-off-by: eder <eder@arista.com>
|
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the SAI_PORT_STAT_IF_IN_FEC_CODEWORD_ERRORS_S[0-15] counter is not available on COUNTERS_DB, the command
show interfaces counters fec-histogramprints all bins with value equals zero without any error message. This change fixes this behavior.What I did
Modified the output of
show interfaces counters fec-histogramcommand when the histogram bins data are not found in the COUNTERS_DB (this is likely to be a bug on modular switches which is under investigation on a separate topic).How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)