[sfputil][sfpshow] Use unified format to show CMIS EEPROM#4333
Open
Junchao-Mellanox wants to merge 1 commit intosonic-net:masterfrom
Open
[sfputil][sfpshow] Use unified format to show CMIS EEPROM#4333Junchao-Mellanox wants to merge 1 commit intosonic-net:masterfrom
Junchao-Mellanox wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Junchao-Mellanox <junchao@nvidia.com>
Junchao-Mellanox
force-pushed
the
master-fix-show-eeprom
branch
from
9b39bf2 to
435d509
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Use unified format to show CMIS EEPROM. The current design checks the SFP type start with "QSFP" and "OSFP". However, there could be other CMIS module such as "CPO". This PR is to fix the issue.
How I did it
If sfp type is start from "OSFP" or the sfp is a CMIS, we will use the same output format.
How to verify it
sonic-utilities UT passed
Manual test passed
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)