Preserve per-ASIC subdirectory structure for sdk_dbg collection#4334
Open
william8545 wants to merge 1 commit intosonic-net:masterfrom
Open
Preserve per-ASIC subdirectory structure for sdk_dbg collection#4334william8545 wants to merge 1 commit intosonic-net:masterfrom
william8545 wants to merge 1 commit intosonic-net:masterfrom
Conversation
…_dbg collection Signed-off-by: William Tsai <willtsai@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed
generate_dumpto preserve per-ASIC subdirectory structure when collectingsdk_dbgfiles into techsupport dumps.How I did it
Extract the relative subdirectory from each file's path under
/var/log/sdk_dbg/and use it as part of the dump destination (e.g.,sai_sdk_dump/0/,sai_sdk_dump/1/), instead of saving all files flat intosai_sdk_dump/. This avoids basename collisions when multiple ASICs produce files with the same timestamp. Single-ASIC systems are unaffected.How to verify it
sai_sdk_dump/contains per-ASIC subdirectories (0/,1/, etc.) with each ASIC's pcap files preserved separately.sai_sdk_dump/remains flat with no regressions.Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)