Fix TrapTightener #1251
Open
Fix TrapTightener #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
swissiety
requested changes
May 20, 2025
Comment on lines
+66
to
+67
| for (Stmt stmt : builder.getStmts()) { | ||
| Map<ClassType, Stmt> exceptionalMap = blockGraph.exceptionalSuccessors(stmt); |
There was a problem hiding this comment.
this is slower than before
Comment on lines
+93
to
+97
| mutatedBlocks.stream().forEach(block -> blockGraph.tryMergeIntoSurroundingBlocks(block)); | ||
|
|
||
| // FIXME: check if there are traphandlers that have no predecessor | ||
|
|
||
| // delete the unused traps | ||
| UnreachableCodeEliminator codeEliminator = new UnreachableCodeEliminator(); | ||
| codeEliminator.interceptBody(builder, view); |
There was a problem hiding this comment.
lets refactor this into a method / simplify
Comment on lines
+85
to
+90
| blockGraph.splitAndExcludeStmtFromBlock(stmt, block); | ||
| for (ClassType classType : entry.getValue()) { | ||
| graph.removeExceptionalEdge(entry.getKey(), classType); | ||
| MutableBasicBlock blockWithUnthrowableException = | ||
| (MutableBasicBlock) blockGraph.getBlockOf(entry.getKey()); | ||
| blockWithUnthrowableException.removeExceptionalSuccessorBlock(classType); | ||
| mutatedBlocks.add(blockWithUnthrowableException); |
There was a problem hiding this comment.
seems like functionality that should only be done in mutablestmtgraph
Comment on lines
+119
to
+122
| if (!monitored.containsKey(currStmt)) { | ||
| monitored.put(currStmt, new HashSet<>()); | ||
| } | ||
| hasChanged = monitored.get(currStmt).add(monitoredValue); |
There was a problem hiding this comment.
performance: reuse get() ---> != null
Comment on lines
+127
to
+128
| if (monitored.containsKey(pred)) { | ||
| for (Value value : monitored.get(pred)) { |
Comment on lines
+131
to
+133
| monitored.put(currStmt, new HashSet<>()); | ||
| } | ||
| hasChanged = monitored.get(currStmt).add(value); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.