Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coretasks: support setname CAP / SETNAME command #2578

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

coretasks: support setname CAP / SETNAME command #2578

wants to merge 3 commits into from

Conversation

dgw
Copy link
Member

@dgw dgw commented Dec 1, 2023

Description

Implements setname spec. coretasks now updates user's realname when receiving SETNAME event.

Sopel does not yet have a means to change its own realname without reconnecting, but changes to the config currently require a bot restart anyway so that's not a big deal.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

Updates user's `realname` when receiving `SETNAME` event.

Sopel does not yet have a means to change its own realname without
reconnecting, but changes to the config currently require a bot restart
anyway so that's not a big deal.
@dgw dgw added this to the 8.1.0 milestone Dec 1, 2023
@dgw dgw linked an issue Dec 1, 2023 that may be closed by this pull request
32 tasks
@dgw dgw removed a link to an issue Dec 1, 2023
32 tasks
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a couple of minor questions really.

test/test_coretasks.py Outdated Show resolved Hide resolved
sopel/coretasks.py Outdated Show resolved Hide resolved
Co-authored-by: Florian Strzelecki <[email protected]>
@dgw dgw requested a review from Exirel December 1, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants