find: support escaping backslash, fix double-bolding, and add basic tests #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
Tests
Bugfix
Exirel
requested changes
Sep 1, 2024
There was a problem hiding this comment.
First, I love that you are using the testing tools for that. I'm happy to see it works quite well. I've suggested a couple of quick changes, that makes the test less reliable on hard-coded value (the user's nick).
I think it would be valuable to add two other tests:
- one where there are 2 users, and one say something, the other use the replace feature
- one where a user replace the replaced line
And with that, I believe we would have a pretty good set of tests.
Co-authored-by: Florian Strzelecki <[email protected]>
Check that correcting someone else's line works as expected, and check that replacing an already-replaced line works as expected. Also check that case-insensitive (i) and global (g) flags work as expected, both separately and together. Note: There is a glitch in formatting when the new replacement occurs inside the previous one, since the bolding used to indicate what changed is kept in the stored line. We might wish to fix that at some point, but the new test correctly represents the real behavior.
Perform the replacement with an unformatted version of the substitute string, then create a display version with bolding added only after the matching line (if any) is found. Updated the corresponding test case. Also renamed some local vars in the `find` plugin file to make a bit more sense (but not too dramatic).
dgw
force-pushed
the
find-escaped-escapechar
branch
from
29e1da0
to
cc2f6e2
Compare
dgw
commented
Sep 2, 2024
dgw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allowing
\|or\/is all well and good, but if one can't escape the escape character, things get very confusing! So let's make it possible to escape\itself as\\.With the test scaffolding now written (OK, much of it stolen from the preexisting
test/builtins/test_builtins_isup.py), it'll be easier to add more cases (edge or otherwise) as we think of them.Checklist
make qa(runsmake lintandmake test)Notes
Early 8.0.x bugfix candidate, unless someone else feels strongly about including it in 8.0.0. Feels late in the game to add One More Thing into that milestone…