test: cover admin functionality of Trigger#2735
Open
SnoopJ wants to merge 1 commit intosopel-irc:masterfrom
Open
test: cover admin functionality of Trigger#2735SnoopJ wants to merge 1 commit intosopel-irc:masterfrom
Trigger#2735SnoopJ wants to merge 1 commit intosopel-irc:masterfrom
Conversation
Member
|
This is getting at what I meant here about "discretizing" different cases. Parametrized tests make each combination a unique test that can pass or fail independently, which I (at least) find helpful when something regresses. That's great :) I would just ask you to consider adding nick-only matching to this matrix for completeness. Possibly also wildcard handling, since that's a feature of the underlying pattern generator: Lines 82 to 93 in f8d536d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2734 by adding a new test that checks that
Trigger.adminis correct for a basicPRIVMSG. Could be expanded for other types of messages but I figured this was a good start.Checklist
make qa(runsmake lintandmake test)