-
Notifications
You must be signed in to change notification settings - Fork 16
[Refactor] #529 - 앱 메모리 최적화(솝탬프, 콕찌르기, 마이페이지, 홈캘린더) #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
430d935
[Refactor] #529 - HomeCalendarDetailVC 메모리 누수 해결
yungu0010 9cffdfe
[Refactor] #529 - AppMyPageVC 메모리 누수 해결
yungu0010 947cdcf
[Refactor] #529 - MissionListVC 클로저 메모리 누수 방지
yungu0010 2943246
[Refactor] #529 - missionListVC에 viewModel 생성자 주입 방식으로 변경
yungu0010 6d3897a
[Fix] #529 - OPNavigatoin 생성자 원래대로 수정
yungu0010 30788f5
[Del] #529 - 불필요한 import문 제거
yungu0010 ac9889a
[Chore] #529 - missionListVC 탭 간격 4로 수정
yungu0010 45983d9
[Refactor] #529 - PokeMainVC와 PokeCoordinator 간 순환참조 제거
yungu0010 25823f8
[Del] #529 - STNavigationBar에서 사용하지 않는 프로퍼티 제거
yungu0010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,21 +57,21 @@ final class PokeCoordinator: DefaultCoordinator { | |
|
||
pokeMain.vm.onPokeButtonTapped = { [weak self] userModel in | ||
guard let self else { return .empty() } | ||
return self.showMessageBottomSheet(userModel: userModel, on: pokeMain.vc.viewController) | ||
return self.showMessageBottomSheet(userModel: userModel, on: self.rootController) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 같은 뷰를 갖고 있었던 솝마디도 똑같은 부분에서 누수가 있었어유. 굿굿 |
||
} | ||
|
||
pokeMain.vm.onNewFriendMade = { [weak self] friendName in | ||
guard let self else { return } | ||
let pokeMakingFriendCompletedVC = self.factory.makePokeMakingFriendCompleted(friendName: friendName).viewController | ||
pokeMakingFriendCompletedVC.modalPresentationStyle = .overFullScreen | ||
pokeMain.vc.viewController.present(pokeMakingFriendCompletedVC, animated: false) | ||
self.rootController?.present(pokeMakingFriendCompletedVC, animated: false) | ||
} | ||
|
||
pokeMain.vm.onAnonymousFriendUpgrade = { [weak self] user in | ||
guard let self else { return } | ||
let pokeAnonymousFriendUpgradeVC = self.factory.makePokeAnonymousFriendUpgrade(user: user).viewController | ||
pokeAnonymousFriendUpgradeVC.modalPresentationStyle = .overFullScreen | ||
pokeMain.vc.viewController.present(pokeAnonymousFriendUpgradeVC, animated: false) | ||
self.rootController?.present(pokeAnonymousFriendUpgradeVC, animated: false) | ||
} | ||
|
||
pokeMain.vm.switchToOnboarding = { [weak self] in | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어쩐지 마이페이지만 진입하면 앱 메모리가 증가한다 했었는데~!