Skip to content

[Fix] #728 - homeFeature 출석 버튼 탭 시 화면 중첩 네비게이션 버그 해결 #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 22, 2025
Merged

[Fix] #728 - homeFeature 출석 버튼 탭 시 화면 중첩 네비게이션 버그 해결 #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39e3163
[Fix] #728 - viewWillDisappear에서 cell 구독 취소 구현
juri123123 Oct 16, 2025
eddad67
[Refactor] #728 - 구현 방식 수정
juri123123 Oct 16, 2025
17f6be1
[Chore] #728 - 함수명 변경
juri123123 Oct 16, 2025
b9cf15f
[Revert] #728 - 변경사항 revert
juri123123 Oct 20, 2025
a4dc412
[Revert] #728 - 변경사항 revert
juri123123 Oct 20, 2025
87eb5d8
[Fix] #728 - cell 구독 정리
juri123123 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...-iOS/Projects/Features/HomeFeature/Sources/HomeScene/Cells/Calendar/CalendarCardCVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,4 +144,9 @@ extension CalendarCardCVC {
}
self.attendanceButton.isHidden = (userType == .visitor || userType == .inactive)
}

func resetSubscription() {
self.cancelBag.cancel()
self.cancelBag = CancelBag()
}
Comment on lines +148 to +151
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수로 분리해주신 것 좋네요!

}
4 changes: 3 additions & 1 deletion ...HomeFeature/Sources/HomeScene/CollectionView/Registration/HomeForMemberItemProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ extension HomeForMemberVC {
func createCalendarCellRegistration() -> CalendarCellRegistration {
collectionView.createCellRegistration { [weak self] cell, _, item in
guard let self else { return }
cell.configureCell(model: item, userType: self.viewModel.userType)

cell.cancelBag.cancel()

cell.configureCell(model: item, userType: self.viewModel.userType)
cell.attendanceButtonTap
.withUnretained(self)
.sink { owner, _ in
Expand Down