[REFACTOR/#1528] Network Error Dialog 통합#1531
Open
seungjunGong wants to merge 8 commits intodevelopfrom
Open
Conversation
…ialog - Remove `FortuneDetailErrorDialog.kt` from the fortune feature. - Update `FortuneDetailScreen.kt` to use the shared `NetworkErrorDialog` component for handling error states.
- Remove local `ErrorDialog` and `NetworkErrorDialog` implementations in `feature/soptamp`. - Migrate to `org.sopt.official.designsystem.component.dialog.NetworkErrorDialog`. - Update `onRetry` callback parameter to `onConfirm` across mission and ranking screens.
- Remove `SoptLogErrorDialog` from `feature/soptlog`. - Update `SoptLogScreen` to use the common `NetworkErrorDialog` from the design system.
- Update copyright year range to 2026 across multiple modules - Add missing MIT license header to `NetworkErrorDialog.kt`
seungjunGong
requested review from
1971123-seongmin,
Hyobeen-Park,
sonms and
vvan2
| .background(color = colors.background.copy(alpha = 0.55f)), | ||
| ) { | ||
| Dialog(onDismissRequest = onCheckClick) { | ||
| Dialog( |
Contributor
There was a problem hiding this comment.
공통 컴포넌트로 OneButtonDialog가 있어서 그거 사용해주면 더 좋을 것 같아요!
1971123-seongmin
approved these changes
Mar 22, 2026
Member
1971123-seongmin
left a comment
1971123-seongmin
left a comment
There was a problem hiding this comment.
드디어 하나로 통합되었네요. 고생하셨어요 🙂🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
Soptamp Dialog의 경우에만 다이얼로그 색상이 다르게 적용되어 있었습니다.
네트워크 에러 다이얼로그는 공통적으로 사용하는 것이 더 적절하다고 판단하여, 전체적으로 동일한 스타일로 통일해 수정해두었습니다.
이 방향으로 진행해도 괜찮을지 확인 해주시면 감사하겠습니다 !