[FEAT] 플레이그라운드 카테고리별 게시물 조회 api에 url 추가 - #504 #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
geniusYoo
reviewed
Mar 24, 2025
| .build(); | ||
| } | ||
|
|
||
| public RecentPostsResponse withUrl(String url) { |
geniusYoo
reviewed
Mar 24, 2025
| .toList()).join(); | ||
| } | ||
|
|
||
| private CompletableFuture<RecentPostsResponse> getHotPost(Map<String, String> headers, ExecutorService executor) { |
There was a problem hiding this comment.
기존 메서드가 뚱뚱하다고 생각했는데 메서드 분리해주신 것 좋습니다! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢