[Fix] 플그로 로그인 시 soptamp 관련 로직 무조건 통과하도록 변경 및 테스트용 로그 삭제 (#516) #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
솝트로그 조회 시 간헐적으로 솝탬프 관련 오류가 뜨는 것을 확인했어요.
해당 오류는 솝트로그 조회 API 중, 솝탬프 랭크를 가져오는 로직에서 발생한 문제인데요.
이 때 soptamp_user에 등록되지 않은 경우 Not Found로 오류가 발생하고 있었어요.
기존에는 플그로 로그인/회원가입 시 기수를 확인 후에 soptamp_user를 생성하거나 기수를 업데이트하는 방식이었는데,
이를 플그로 로그인/회원가입 시에 사용자의 최근 기수로 soptamp_user를 무조건 생성하거나 업데이트하도록 변경했어요.
sopt-backend/src/main/java/org/sopt/app/facade/AuthFacade.java
Lines 42 to 44 in 5eb2b98
sopt-backend/src/main/java/org/sopt/app/facade/AuthFacade.java
Line 42 in 092b671
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢