[Fix] 솝탬프 랭크 null인 경우 문자열 처리 #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the soptampRank handling in the UserResponse to display "공개 예정!" when the rank value is null, in light of the temporary suspension of 솝탬프.
- Changed the soptampRank field to return "public 예정!" instead of an empty string when null
- Added an inline comment to clarify the rationale for the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
솝탬프 일시 중단으로 인해 "공개 예정!" 이라는 문자열이 내려오도록 수정했어요.
sopt-backend/src/main/java/org/sopt/app/presentation/user/UserResponse.java
Line 173 in aedf20f
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢