[Fix] 솝트로그, 솝탬프 관련 이슈 해결 (#527) #528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
솝트로그 관련 이슈를 해결합니다.
1. 솝트로그 기수
미상값 제거sopt-backend/src/main/java/org/sopt/app/presentation/user/UserResponse.java
Lines 176 to 179 in 6c980c6
2. 솝트로그 명예오비 오류나는 이슈 해결
isActive를 판단하는 기준이 모호하여 오류가 있었어요.sopt-backend/src/main/java/org/sopt/app/presentation/user/UserController.java
Lines 111 to 116 in 6c980c6
3. 솝트로그 솝탬프 등수 다시 오픈
equals()비교가 아닌Boolean.TRUE.equals(isActive)로 안전하게 비교하도록 했어요.sopt-backend/src/main/java/org/sopt/app/presentation/user/UserController.java
Lines 120 to 122 in 3ab8d0d
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢