Skip to content

[Fix] AWS Credential 시크릿에서 주입받아 배포하도록 수정 (#548) #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

[Fix] AWS Credential 시크릿에서 주입받아 배포하도록 수정 (#548) #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d2aba6
[Refactor] env 파일 생성 후 시크릿 값 주입 (#548)
geniusYoo Apr 25, 2025
93937cb
[Refactor] 기존 AwsConfig 키 설정 로직 제거 (#548)
geniusYoo Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/app-cd-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ jobs:
key: ${{ secrets.DEV_PEM_KEY }}
script: |
cd ~
sudo chmod +x ./app/script/*.sh
./app/script/deploy.sh
cd ./app
echo "Creating .env file..."
echo "AWS_ACCESS_KEY_ID=${{ secrets.AWS_ACCESS_ID }}" > .env
echo "AWS_SECRET_ACCESS_KEY=${{ secrets.AWS_SECRET_KEY }}" >> .env

sudo chmod +x ./script/*.sh
./script/deploy.sh
docker image prune -f
11 changes: 0 additions & 11 deletions src/main/java/org/sopt/app/common/config/AwsConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package org.sopt.app.common.config;

import com.amazonaws.auth.AWSCredentials;
import com.amazonaws.auth.AWSStaticCredentialsProvider;
import com.amazonaws.auth.BasicAWSCredentials;
import com.amazonaws.services.s3.AmazonS3;
import com.amazonaws.services.s3.AmazonS3ClientBuilder;
import org.springframework.beans.factory.annotation.Value;
Expand All @@ -12,21 +9,13 @@
@Configuration
public class AwsConfig {

@Value("${cloud.aws.credentials.access-key}")
private String accessKey;

@Value("${cloud.aws.credentials.secret-key}")
private String secretKey;

@Value("${cloud.aws.region.static}")
private String region;

@Bean
public AmazonS3 amazonS3() {
AWSCredentials awsCredentials = new BasicAWSCredentials(accessKey, secretKey);
return AmazonS3ClientBuilder.standard()
.withRegion(region)
.withCredentials(new AWSStaticCredentialsProvider(awsCredentials))
.build();
}
}