[Feat] #609 솝탬프 테스트 코드 작성

src/main/java/org/sopt/app/application/mission/MissionService.java

@@ -5,6 +5,8 @@
 import java.util.function.Predicate;
 import lombok.RequiredArgsConstructor;
 import lombok.val;
+import org.sopt.app.common.exception.NotFoundException;
+import org.sopt.app.common.response.ErrorCode;
 import org.sopt.app.domain.entity.soptamp.Mission;
 import org.sopt.app.domain.entity.soptamp.Stamp;
 import org.sopt.app.interfaces.postgres.MissionRepository;
@@ -82,10 +84,10 @@ public List<Mission> getIncompleteMission(Long userId) {
         return missionRepository.findMissionInOrderByLevelAndTitleAndDisplayTrue(inCompleteIdList);
     }
 
-    public MissionInfo.Level getMissionById(Long missionId) {
+    public MissionInfo.Level getMissionLevelById(Long missionId) {
         val mission = missionRepository.findById(missionId).orElseThrow(
-                () -> new IllegalArgumentException("해당 미션을 찾을 수 없습니다.")
-        );
+            () -> new NotFoundException(ErrorCode.MISSION_NOT_FOUND));
+
         return MissionInfo.Level.of(mission.getLevel());
     }
 

src/main/java/org/sopt/app/application/stamp/StampInfo.java

@@ -24,5 +24,17 @@ public static class Stamp {
         private String activityDate;
         private LocalDateTime createdAt;
         private LocalDateTime updatedAt;
+
+        public static Stamp from(org.sopt.app.domain.entity.soptamp.Stamp stamp) {
+            return StampInfo.Stamp.builder()
+                .id(stamp.getId())
+                .contents(stamp.getContents())
+                .images(stamp.getImages())
+                .activityDate(stamp.getActivityDate())
+                .missionId(stamp.getMissionId())
+                .createdAt(stamp.getCreatedAt())
+                .updatedAt(stamp.getUpdatedAt())
+                .build();
+        }
     }
 }

src/main/java/org/sopt/app/application/stamp/StampService.java

@@ -34,15 +34,7 @@ public StampInfo.Stamp findStamp(Long missionId, Long userId) {
         val entity = stampRepository.findByUserIdAndMissionId(userId, missionId)
                 .orElseThrow(() -> new BadRequestException(ErrorCode.STAMP_NOT_FOUND));
         entity.validate();
-        return StampInfo.Stamp.builder()
-                .id(entity.getId())
-                .contents(entity.getContents())
-                .images(entity.getImages())
-                .activityDate(entity.getActivityDate())
-                .createdAt(entity.getCreatedAt())
-                .updatedAt(entity.getUpdatedAt())
-                .missionId(entity.getMissionId())
-                .build();
+        return StampInfo.Stamp.from(entity);
     }
 
     @Transactional
@@ -54,15 +46,8 @@ public StampInfo.Stamp uploadStampDeprecated(
         val imgList = new ArrayList<>(imgPaths);
         val stamp = this.convertStampImgDeprecated(stampRequest, imgList, userId, missionId);
         val newStamp = stampRepository.save(stamp);
-        return StampInfo.Stamp.builder()
-                .id(newStamp.getId())
-                .contents(newStamp.getContents())
-                .images(newStamp.getImages())
-                .activityDate(newStamp.getActivityDate())
-                .createdAt(newStamp.getCreatedAt())
-                .updatedAt(newStamp.getUpdatedAt())
-                .missionId(newStamp.getMissionId())
-                .build();
+
+        return StampInfo.Stamp.from(newStamp);
     }
 
     @Transactional
@@ -78,15 +63,7 @@ public StampInfo.Stamp uploadStamp(
                 .build();
 
         val newStamp = stampRepository.save(stamp);
-        return StampInfo.Stamp.builder()
-                .id(newStamp.getId())
-                .contents(newStamp.getContents())
-                .images(newStamp.getImages())
-                .activityDate(newStamp.getActivityDate())
-                .createdAt(newStamp.getCreatedAt())
-                .updatedAt(newStamp.getUpdatedAt())
-                .missionId(newStamp.getMissionId())
-                .build();
+        return StampInfo.Stamp.from(newStamp);
     }
 
     @Transactional

src/main/java/org/sopt/app/facade/RankFacade.java

@@ -102,7 +102,7 @@ public PartRank findPartRank(Part part) {
 
     @Transactional(readOnly = true)
     public Long findUserRank(Long userId) {
-        Set<TypedTuple<Long>> sortedScoreCaches =  rankCacheService.getRanking();
+        Set<TypedTuple<Long>> sortedScoreCaches = rankCacheService.getRanking();
         if (sortedScoreCaches != null && !sortedScoreCaches.isEmpty()) {
             Long rank = 1L;
             for(TypedTuple<Long> cache : sortedScoreCaches){

src/main/java/org/sopt/app/facade/SoptampFacade.java

@@ -2,7 +2,6 @@
 
 import java.util.List;
 
-import jakarta.annotation.PostConstruct;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import lombok.val;
@@ -39,7 +38,7 @@ public class SoptampFacade {
     public Stamp uploadStamp(Long userId, RegisterStampRequest registerStampRequest){
         stampService.checkDuplicateStamp(userId, registerStampRequest.getMissionId());
         Stamp result = stampService.uploadStamp(registerStampRequest, userId);
-        Level mission = missionService.getMissionById(registerStampRequest.getMissionId());
+        Level mission = missionService.getMissionLevelById(registerStampRequest.getMissionId());
         soptampUserService.addPointByLevel(userId, mission.getLevel());
         return result;
     }
@@ -52,7 +51,7 @@ public Stamp editStamp(Long userId, StampRequest.EditStampRequest request){
     @Transactional
     public void deleteStamp(Long userId, Long stampId){
         val stamp = stampService.getStampForDelete(stampId, userId);
-        val mission = missionService.getMissionById(stamp.getMissionId());
+        val mission = missionService.getMissionLevelById(stamp.getMissionId());
         soptampUserService.subtractPointByLevel(userId, mission.getLevel());
 
         stampService.deleteStampById(stampId);