Skip to content

[feat] 박수 기능 엔티티(Stamp, Clap) 구조 추가 및 동시성 대응 - #623 #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2025
Merged

[feat] 박수 기능 엔티티(Stamp, Clap) 구조 추가 및 동시성 대응 - #623 #625

merged 3 commits into from
Oct 17, 2025

Conversation

@hyerinhwang-sailin
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  1. Stamp 엔티티 확장
  • clap_count, view_count, version 필드 추가
  • 게시글별 총 박수/조회수 집계용 필드
  • 낙관적 락(@Version)으로 동시성 제어 준비
  • contents, images, activityDate 유효성 검증 로직 유지
  1. Clap 엔티티 신규 생성
  • (stamp_id, user_id) 유니크 제약으로 유저별 단일 레코드 보장
  • clap_count 0~50 제약(@check)으로 상한 보장
  • 낙관적 락(@Version) 추가 (동시 요청 재시도 대응)
  • incrementClapCount() 로직으로 클라의 debounce 요청 처리
  1. 정합성 / 동시성 고려
  • 기본은 낙관적 락(@Version) 기반 처리
  • 핫스팟 구간은 원자적 SQL(UPDATE ... RETURNING)로 대응 예정

Trouble Shooting ⚽️

Related ScreenShot 📷

Uncompleted Tasks 😅

To Reviewers 📢

@hyerinhwang-sailin hyerinhwang-sailin linked an issue Oct 17, 2025 that may be closed by this pull request
[FEAT] 솝탬프 박수 기능 구현 #623
Closed
1 task
@hyerinhwang-sailin hyerinhwang-sailin self-assigned this Oct 17, 2025
jher235
jher235 approved these changes Oct 17, 2025
View reviewed changes
huncozyboy
huncozyboy approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@huncozyboy huncozyboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

따로 리뷰할 만한 내용은 없었던거같아요

src/main/java/org/sopt/app/domain/entity/soptamp/Clap.java
columnNames = {"stamp_id", "user_id"}
)
)
@Check(constraints = "clap_count >= 0 AND clap_count <= 50")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB 가드도 좋네요 👍🏻👍🏻

src/main/java/org/sopt/app/domain/entity/soptamp/Stamp.java
Comment on lines +41 to +42
@Version
private Long version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR에 적어주신대로 낙관적 락을 위한 필드로 이해하고 있을게요 ~~

@hyerinhwang-sailin hyerinhwang-sailin merged commit a6b4cbc into dev Oct 17, 2025
1 check passed
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(Clap): incrementClapCount 반환값 수정
b2b63cc
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(ClapRepository): 복합키 조회(findByUserIdAndStampId) 추가
16511b0
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(StampRepositoryCustom): incrementClapCountReturning 정의
b5307cf
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(StampRepositoryImpl): Postgres RETURNING 기반 원자 증가 구현 (cla…
0994251 
…p_count, version 동시 증가)
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(StampRepository): extend StampRepositoryCustom
4dcd1ed
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(ClapService): 유저별 박수 상한(50) 및 총합 반영 로직
7dea797
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(ClapRequest): AddClapRequest: 요청 증가량 검증 (@positive)
4705e20
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(ClapResponse): AddClapResponse 추가
1e185c3
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(ErrorCode): clap 관련 error code 추가
344bfd9
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(SoptampFacade): 박수 관련 로직 위임
b23c235
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(StampResponseMapper): ClapResponse 변환 메서드 추가
bcfd21c
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(StampService): getStampClapCount 추가
100f509
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(StampController): /{stampId}/clap 엔드포인트 추가
45a707e
hyerinhwang-sailin added a commit that referenced this pull request Oct 17, 2025
@hyerinhwang-sailin
[#625] feat(ClapServiceTest): 정상 증가, 상한 컷팅, 50 도달, 자기글 금지, 잘못된 입력, 락 …
478e801 
…재시도 시나리오 검증
hyerinhwang-sailin added a commit that referenced this pull request Oct 18, 2025
@hyerinhwang-sailin
[feat] 솝탬프 박수 기능 구현 - #625 (#626)
855222d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jher235 jher235 jher235 approved these changes

@huncozyboy huncozyboy huncozyboy approved these changes

Assignees

@hyerinhwang-sailin hyerinhwang-sailin

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT] 솝탬프 박수 기능 구현

3 participants

@hyerinhwang-sailin @jher235 @huncozyboy