[feat] 솝탬프 박수 기능 구현 - #625 #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p_count, version 동시 증가)
Closed
1 task
jher235
approved these changes
Oct 18, 2025
Comment on lines
+89
to
+101
| private Clap createClapSafely(Long userId, Long stampId) { | ||
| try { | ||
| Clap fresh = Clap.builder() | ||
| .userId(userId) | ||
| .stampId(stampId) | ||
| .clapCount(0) | ||
| .build(); | ||
| return clapRepository.saveAndFlush(fresh); | ||
| } catch (DataIntegrityViolationException e) { | ||
| return clapRepository.findByUserIdAndStampId(userId, stampId) | ||
| .orElseThrow(() -> e); | ||
| } | ||
| } |
There was a problem hiding this comment.
이렇게 생성하는 경우에 clapCount까지 한번에 반영하지 않고 insert, update 를 진행하도록 하신 이유가 있을까요??
There was a problem hiding this comment.
새 Clap 행을 만들 때 바로 clapCount를 더하면
생성 시점 경합이나 상한 계산이 SQL 단으로 분산돼 정합성 관리가 어려워져서
항상 0으로 초기화 후, 증가 로직을 단일 경로(incrementClapCount())로 통일하고자 했습니다!
huncozyboy
approved these changes
Oct 18, 2025
Comment on lines
+113
to
+114
| int appliedCount = soptampFacade.addClap(userId, stampId, request.getClapCount()); | ||
| int totalClapCount = soptampFacade.getStampClapCount(stampId); |
There was a problem hiding this comment.
읽기, 쓰기 연산도 파사드로 분리 호출돼서 잘 설계해주신거같아요 👍🏻
Comment on lines
+23
to
+24
| @ExtendWith(MockitoExtension.class) | ||
| class ClapServiceTest { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
동시성/락 설계 의사결정 배경
추가로, (stamp_id, user_id) 유니크 제약으로 최초 생성 경합은 DB가 보장하고, 충돌 시 재조회로 해결.
=> 결론: Clap은 낙관적 락 + 재시도가 성능·단순성·정합성을 동시에 만족.
=> 결론: Stamp 총합은 **네이티브 원자 증가(RETURNING)**가 고경합 시나리오에서 가장 안정적·효율적.
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢