[Fix] 푸시알림 딥링크/대상 수정, 발송 안정화 - #632 #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…타임은 RestClientException으로 래핑
…lestoneGuard.tryMarkFirstHit를 기본 @transactional(REQUIRED)로 변경
jher235
reviewed
Oct 21, 2025
Comment on lines
+6
to
+17
| public final class SoptampDeepLinkBuilder { | ||
| private static final String BASE = | ||
| "home/soptamp/entire-part-ranking/part-ranking/missions/missionDetail"; | ||
|
|
||
| private SoptampDeepLinkBuilder() {} | ||
|
|
||
| public static String buildStampDetailLink(long stampId, boolean isMine, String nickname, String part) { | ||
| String encodedNickname = URLEncoder.encode(nickname, StandardCharsets.UTF_8); | ||
| return String.format("%s?id=%d&isMine=%s&nickname=%s&part=%s", | ||
| BASE, stampId, Boolean.toString(isMine), encodedNickname, part); | ||
| } | ||
| } |
There was a problem hiding this comment.
저희 미션 조회할 때 missionId와 nickname으로 API를 조회할텐데 딥링크에 missionId 는 없어도 괜찮을까요??
There was a problem hiding this comment.
이거 클라 쪽에 재확인해봐야할 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
개요
ClapMilestoneGuard트랜잭션 정책을 조정했습니다.변경 사항 (Commits)
home/soptamp/entire-part-ranking/part-ranking/missions/missionDetail?id={id}&isMine={bool}&nickname={encoded}&part={part}ofOwnerClapFirst(...): 첫 박수ofOwnerClap100Or500(...): 100/500번째ofOwnerClapKilo(...): 1000 단위(1000/2000/…)isMine=true로 이동RestTemplate빈 주입 전환 및 발송 실패 로깅 보강new RestTemplate()제거 → 공통 빈 사용ClapRequest변경사항 반영(새 팩토리 호출)RuntimeException보존RestClientException으로 의미 있는 래핑tryMarkFirstHit를 기본 @transactional(REQUIRED) 로 변경@Transactional(REQUIRES_NEW)에 참여하여 마킹+발송 동시 커밋/롤백설계 의도 / 이유
clap_milestone_hit의 UNIQUE(stamp_id, milestone) +INSERT ... ON CONFLICT DO NOTHINGRestTemplate빈 + 개선된 예외 처리/로깅으로 운영 가시성 향상Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢