Spring AOP + Logback 로깅 시스템 적용 #793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-Crayon
added
medium priority
기존의 가독성 떨어지는 StackTrace 제거 및 이모지 추가 Related to: #782
Lim-Changi
reviewed
Oct 21, 2025
Comment on lines
+125
to
+132
| StackTraceElement firstTrace = exception.getStackTrace()[0]; | ||
| errorLog.put("errorLocation", | ||
| String.format("%s.%s:%d", | ||
| firstTrace.getClassName(), | ||
| firstTrace.getMethodName(), | ||
| firstTrace.getLineNumber() | ||
| ) | ||
| ); |
There was a problem hiding this comment.
이 부분에서 GlobalExceptionHandler 와 동일하게 아래와 같은 예외 처리가 필요할 것 같습니다!
if (exception.getStackTrace().length == 0) {}
제가 파악한 요청 처리 순서는 다음과 같은데,
- 요청 들어옴
- RequestIdFilter
- HttpLoggingAspect - Around()
→ logRequest() 실행 - 실제 Controller 메서드 실행
→ Exception 발생 - HttpLoggingAspect의 catch 블록
→ logError() 실행 - 예외 throw error
- GlobalExceptionHandler 실행
위에서 말씀드린 예외처리가 없다면 5번 logError() 처리 중에
stackTrace 가 없으면, ArrayIndexOutOfBoundsException 오류가 날 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐬 요약
Spring AOP + Logback 로깅 시스템 적용
👻 유형
PR의 유형에 맞게 체크해주세요!
🍀 작업 내용
PR에 담긴 작업 내용을 작성해주세요!
🌟 관련 이슈
해당 기능 배포전에 yml에 존재하는 tomcat accesslog 관련 설정을 지워야합니다 (dev + prod)
컨트롤러에 들어오는 request와 그에 따른 response나 error가 모두 관리되기때문에 중복해서 로그를 생성할 필요가 없습니다.
close: #782