Don't allow sanitize in BS popover - #728
Conversation
In [BS v3.4.1](https://github.com/twbs/bootstrap/blob/v3.4.1/js/popover.js#L51) tooltips and popovers sanitize HTML by default, thus removing navigation buttons from the tour.
|
Sorry, I feel like I'm repeatedly posting the same thing on this issue. Turning off the sanitizer as per your patch will fix the issue, but will introduce a potential security vulnerability due to XSS etc depending on how your code works. I strongly suggest that you change your patch to specifically whitelist the button elements, or use my fork which exposes options to do this for you. See #729 |
|
My bad, I did not investigate the code thoroughly enough. But I can imagine other projects, where this issue arises and someone disables BS sanitization globally as a quick fix, with far more bad consequences than good ones. IMHO it should work out of the box, at least with BS 3.4. And only sanitize user-supplied contents of templates, if not explicitly requested otherwise. |
|
I would recommend using @IGreatlyDislikeJavascript fork It is working much better. |
In BS v3.4.1 tooltips and popovers sanitize HTML by default, thus removing navigation buttons from the tour.