[aap_containerized] collect podman inspect logs - #4064
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
arif-ali
left a comment
There was a problem hiding this comment.
You are removing podman logs and adding podman inspect, should we not collect both?
I don't know enough about podman, this is where I need to be educated :)
|
|
||
| # Copy podman container log files in plugin sub directory | ||
| # under aap_containers_log | ||
| # Copy podman container log and inspect files into their respective subdirectories |
There was a problem hiding this comment.
please ensure that the characters on this line are no more than 79 characters
| suggest_filename=f"{log_file}", | ||
| subdir="aap_containers_log" | ||
| suggest_filename=f"{container}.log", | ||
| subdir="aap_container_logs" |
There was a problem hiding this comment.
any reason why you're changing this? I'm no RH expert, but if the RH folks have any automation against the old filename or people are looking for the old name, then this shouldn't change
There was a problem hiding this comment.
@arif-ali this is just a place-holder directory. It never mattered and i incorrectly named initially as aap_containers_log instead of aap_container_logs which sounds more logical.
If you observe the change we do collect both |
Signed-off-by: Nagoor Shaik <nshaik@redhat.com>
you're right, I totally saw through the change, my bad |
|
btw, have you tried the |
I tried it initially, it never worked for me. Same was discussed here #4030 (comment) @TurboTurtle said he will look into it later. |
The issue there was using I'm hoping to have some time in the next month or so to get non-root container introspection hooked up. |
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines