[mssql] Remove redundant all_logs conditional branch#4268
Merged
arif-ali merged 1 commit intososreport:mainfrom Mar 10, 2026
Merged
[mssql] Remove redundant all_logs conditional branch#4268arif-ali merged 1 commit intososreport:mainfrom
arif-ali merged 1 commit intososreport:mainfrom
Conversation
The if/else block at lines 81-86 was dead code: both branches performed identical add_copy_spec() calls, and the same paths were already collected unconditionally at lines 75-79. This redundancy dates back to commit 967c015, which moved sizelimit handling into the framework. The original branches had differed only in their sizelimit arguments, but after that refactor the two branches became identical, leaving a no-op conditional behind. While the framework deduplicates copy_paths (stored as a set), removing this block improves readability and avoids confusion about the intended role of the all_logs option in this plugin. Signed-off-by: reidliu41 <reid201711@gmail.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
arif-ali
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The if/else block at lines 81-86 was dead code: both branches
performed identical add_copy_spec() calls, and the same paths
were already collected unconditionally at lines 75-79.
This redundancy dates back to commit 967c015, which moved
sizelimit handling into the framework. The original branches
had differed only in their sizelimit arguments, but after that
refactor the two branches became identical, leaving a no-op
conditional behind.
While the framework deduplicates copy_paths (stored as a set),
removing this block improves readability and avoids confusion
about the intended role of the all_logs option in this plugin.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines