Skip to content

[Policy] Fix os_release_name value#4269

Merged
pmoravec merged 1 commit intososreport:mainfrom
eric-desrochers:azurelinux
Mar 10, 2026
Merged

[Policy] Fix os_release_name value#4269
pmoravec merged 1 commit intososreport:mainfrom
eric-desrochers:azurelinux

Conversation

@eric-desrochers
Copy link
Contributor

OS_RELEASE_NAME was previously matching PRETTY_NAME instead of the intended NAME identifier. This could cause incorrect OS validation and defaulting to the "Upstream Project:" instead.

Adjusted the logic to correctly validate OS identifiers and prevent falling back to default unexpectedly.

$ grep NAME /etc/os-release
NAME="Azure Linux"
PRETTY_NAME="Microsoft Azure Linux 3.0"


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

OS_RELEASE_NAME was previously matching PRETTY_NAME instead of
the intended NAME identifier. This could cause incorrect OS
validation and defaulting to the "Upstream Project:" instead.

Adjusted the logic to correctly validate OS identifiers and
prevent falling back to default unexpectedly.

$ grep NAME /etc/os-release
NAME="Azure Linux"
PRETTY_NAME="Microsoft Azure Linux 3.0"

Signed-off-by: Eric Desrochers <edesrochers@microsoft.com>
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4269
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali arif-ali added Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Mar 10, 2026
@pmoravec pmoravec merged commit 48c34be into sosreport:main Mar 10, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants