[testing] Migrate CI to GH Workflow - #4310
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
1 similar comment
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
05b11e0 to
0bc241f
Compare
0bc241f to
8891aee
Compare
pmoravec
left a comment
There was a problem hiding this comment.
Looks great (as far as I my limited knowledge of GH workflows reach..)!
8891aee to
77ff42a
Compare
|
The failed: is expected on systems with empty / no journals - see https://github.com/sosreport/sos/blob/main/sos/report/plugins/logs.py#L81-L85 . The https://github.com/sosreport/sos/blob/main/tests/report_tests/plugin_tests/logs.py#L27 must be called conditionally (or never). |
77ff42a to
8e0a173
Compare
|
I am trying to work through this, as fedora and centos is container based, so figuring things out, hence still WiP. I'm conscious that we are closing towards EoL of Cirrus |
ffb64b1 to
565d1ca
Compare
|
if anyone knows how to get systemd working in a docker container for fedora/centos, then that would be awesome, that's the last bit to get the stage one tests working under GH workflow/actions. I have tried many things first in my own Canonical repo, and some today. I'll keep researching, and see if I can find anything, but if you already have tackled it, then that could be useful |
|
First of all, thank you so much @arif-ali for doing this! quay.io/centos-bootc/centos-bootc:stream9 Other than that, I think the other way would be to use a modified dockerfile and I'm not sure how feasible is that. I wonder if we could actually create sos-specific images in quay.io that are lightweight and also have systemd enabled, just for testing, but I'm not an expert in containers so maybe anybody else knows if it can be done and it's worth it? Same for Fedora, these are the ones I've found: quay.io/fedora/fedora-bootc:43 Does that help? |
38ab094 to
8171f3a
Compare
|
No much knowledge on this topic. I can try to learn & dig in, if necessary - if so, please describe the issue more specifically. Checking one particular error:
It is because AFAIK the service isnt usually present in containers. So if we want to run these journal tests inside containers, we must modify the service-enabling condition (to |
789168f to
fa1d6e3
Compare
Based on the current test, the bootc image doesn't work in stageone tests, but the normal one does 🤷🏽, and this is with all the skips for systemd/journal. Something about |
1a61f6f to
78512a9
Compare
|
What about the option of creating sos-specific centos-stream docker images in quay.io? I imagine that in that scenario we could control the dockerfile and have a combination of the base image + the bootc image (and give us more flexibility in the future if we want to add more things) |
That's an option, I think we did similar in Cirrus world way before I joined the project here. Seems like you have to pay to get images on there, unless you have some insider thing that allows you to do this. I would be open to that, as long as other folks here would also be happy with that too. We are so close in closing this off and getting it to work, I'll see if I can do something similar to these last failures with skipIf decorators or variables to skip these for now, and we can work on the new containers with less pressure on getting this done for the end of the month |
OK, let me investigate what options do we have and if there's no free tier, if we can get sponsored.
Agreed, lets finish this up before the deadline in 10 days and then we can work on making it "perfect". Once this PR is merged, I'll open a new one where we can experiment further. Thank you again @arif-ali ! |
b48cc66 to
4f7f010
Compare
|
Right, this should be it now, there are issues with snapstore at the moment, but I know the ubuntu side will pass once the snapstore infra is good. So, reviews from the team would be awesome |
4f7f010 to
1e9e326
Compare
919daf1 to
947c038
Compare
Initial work adds Ubuntu, CentOS and Fedora * CentOS and Fedora as docker containers. * Fedora for stagetwo depends on py3.14 enablement for avocado, so this has been postponed for later. * CentOS foreman tests to be added later, docker container and foreman may not behave as well. * Tests for systemd and/or journals have been skipped for docker containers for the time being. * Debian will be added later. * 26.04 enablement is same as Fedora, plus waiting for the runners to be available in GH Related: sosreport#4288 Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
947c038 to
d866d6a
Compare
|
Comparing tests and builds triggered before and after:
Thanks again for all the huge work, @arif-ali ! |
That's what we were doing before?
These are LTS releases, and GH native runners are available. 26.04 is still pending to be added by GH, so that's a waiting game. For intermediate releases GH doesn't do runners, so we may need to do containers for those. So, some extra work is required there. It would be good to do it, but thought as they are only supported for 9 months, and the latest 25.10 is only supported for another month didn't make sense.
Totally understand, the RH and Debian both need adding here, but as these will be done in docker, this may take some time to get done, but it's in my plan to do it. I'm away some of next week and today, and have other work on my radar, so wasn't going to have time to complete all of it
The py tests are the breakage tests, which tests python 3.9 and latest 3.x
Again, docker related, so need to spend extra time to fine tune it all to get these going, it's on my radar to do
No worries at all |
pmoravec
left a comment
There was a problem hiding this comment.
Ack from me, thanks for all the work done.
Not sure if we should wait for @TurboTurtle review as well, to have full consensus here. As the change is quite substantial..
Per some other PR and its tests, yes :) but as I wrote, I see no much benefit in those.
LGTM.
+1, plus I should have this on my radar for the
Ah, I was blind, thx. |
TurboTurtle
left a comment
There was a problem hiding this comment.
Ack. Thanks for taking this on! This was a real curveball from Cirrus, and this is a very strong pivot.
|
Holding merge for ~24 hours for final comments given the size and scope of this. |
may not behave as well.
containers for the time being.
be available in GH
Related: #4288
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines