[workflow] Fix workflow for docs and code changes - #4379
Merged
Conversation
arif-ali
force-pushed
the
sos-arif-workflow-test
branch
2 times, most recently
from
July 3, 2026 08:10
e163265 to
a5e0f4d
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
arif-ali
force-pushed
the
sos-arif-workflow-test
branch
9 times, most recently
from
July 8, 2026 13:03
a0c5f8a to
59be603
Compare
arif-ali
marked this pull request as ready for review
July 8, 2026 13:04
Member
Author
|
I have just tested this in our own repos at https://github.com/canonical/sos, and this should now work. Seems like GH Workflow design is a dark art to get right |
arif-ali
force-pushed
the
sos-arif-workflow-test
branch
from
July 14, 2026 09:43
59be603 to
5498f8a
Compare
pmoravec
reviewed
Jul 17, 2026
pmoravec
approved these changes
Jul 17, 2026
Using count in terms of what changes is more predictable than the previous method. Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
arif-ali
force-pushed
the
sos-arif-workflow-test
branch
from
July 17, 2026 14:08
5fda1dc to
a5ea4dc
Compare
Member
Author
|
Also fixed a pylint issue, that wasn't picked up over the past couple of weeks due to workflow issues |
pmoravec
reviewed
Jul 17, 2026
Some of the tests had not run due to the filters issue. This is to solve the pylint issues missed Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
arif-ali
force-pushed
the
sos-arif-workflow-test
branch
from
July 17, 2026 14:42
a5ea4dc to
28ec7f4
Compare
pmoravec
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines