Skip to content

[workflow] Fix workflow for docs and code changes - #4379

Merged
arif-ali merged 3 commits into
sosreport:mainfrom
arif-ali:sos-arif-workflow-test
Jul 17, 2026
Merged

[workflow] Fix workflow for docs and code changes#4379
arif-ali merged 3 commits into
sosreport:mainfrom
arif-ali:sos-arif-workflow-test

Conversation

@arif-ali

@arif-ali arif-ali commented Jul 3, 2026

Copy link
Copy Markdown
Member

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@arif-ali
arif-ali force-pushed the sos-arif-workflow-test branch 2 times, most recently from e163265 to a5e0f4d Compare July 3, 2026 08:10
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4379
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
arif-ali force-pushed the sos-arif-workflow-test branch 9 times, most recently from a0c5f8a to 59be603 Compare July 8, 2026 13:03
@arif-ali arif-ali changed the title TEST: workflow test [workflow] Fix workflow for docs and code changes Jul 8, 2026
@arif-ali
arif-ali marked this pull request as ready for review July 8, 2026 13:04
@arif-ali

arif-ali commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

I have just tested this in our own repos at https://github.com/canonical/sos, and this should now work.

Seems like GH Workflow design is a dark art to get right

@arif-ali
arif-ali force-pushed the sos-arif-workflow-test branch from 59be603 to 5498f8a Compare July 14, 2026 09:43
@arif-ali arif-ali added Status/Needs Review This issue still needs a review from project members Kind/Testing Related to Testing labels Jul 14, 2026
@arif-ali
arif-ali requested review from TurboTurtle and pmoravec July 15, 2026 08:48
Comment thread .github/workflows/main-pipeline.yaml
arif-ali added 2 commits July 17, 2026 15:01
Using count in terms of what changes is more predictable than the
previous method.

Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
@arif-ali
arif-ali force-pushed the sos-arif-workflow-test branch from 5fda1dc to a5ea4dc Compare July 17, 2026 14:08
@arif-ali

Copy link
Copy Markdown
Member Author

Also fixed a pylint issue, that wasn't picked up over the past couple of weeks due to workflow issues

Comment thread sos/report/plugins/foremanctl.py Outdated
Some of the tests had not run due to the filters issue. This is to solve
the pylint issues missed

Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
@arif-ali
arif-ali force-pushed the sos-arif-workflow-test branch from a5ea4dc to 28ec7f4 Compare July 17, 2026 14:42
@arif-ali
arif-ali merged commit 045bb37 into sosreport:main Jul 17, 2026
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind/Testing Related to Testing Status/Needs Review This issue still needs a review from project members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants